fix: editorState.document validation error exceeds limit length #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 62.42% 62.42%
=======================================
Files 266 266
Lines 59143 59145 +2
Branches 3796 3796
=======================================
+ Hits 36920 36922 +2
Misses 22148 22148
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atonaamz
reviewed
Oct 20, 2025
| languageName: generateCompletionReq.fileContext?.programmingLanguage?.languageName, | ||
| }, | ||
| text: textDocument.getText(), | ||
| // Naive truncation, maybe we need "10240" characters around current curosr position instead |
Contributor
There was a problem hiding this comment.
have we aligned with service on this truncation?
atonaamz
approved these changes
Oct 20, 2025
bywang56
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
validationError is thrown when users trigger a nep request in a large file because
editorState.documentcan only be 40000 chars longSolution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.